Skip to content

fix: correctly save chart removal progress after subsequent chart removal fails - #5492

Merged
brandtkeller merged 4 commits into
mainfrom
fix-empty-slice-in-failed-remove
Oct 21, 2026
Merged

fix: correctly save chart removal progress after subsequent chart removal fails#5492
brandtkeller merged 4 commits into
mainfrom
fix-empty-slice-in-failed-remove

Conversation

@AustinAbro321

@AustinAbro321 AustinAbro321 commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

We were saving an empty chart after one chart was successfully deleted and the next chart failed. This caused an invalid secret that a user would have to manually edit.

Related Issue

Fixes #5491

Checklist before merging

@AustinAbro321
fix empty slice in failed remove
b93135e 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
remove test
87004cd 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
simpler test
b9fed25 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
AustinAbro321 requested review from a team as code owners October 19, 2026 14:51
@netlify

netlify Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

βœ… Deploy Preview for zarf-docs canceled.

Name Link
πŸ”¨ Latest commit c42bcf6
πŸ” Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6ad8c0498b65c1823c03a0a2

@AustinAbro321 AustinAbro321 changed the title fix: correctly apply chart state after failed chart removal fix: correctly apply chart removal progress after failed chart removal Oct 19, 2026
@AustinAbro321 AustinAbro321 changed the title fix: correctly apply chart removal progress after failed chart removal fix: correctly apply chart removal progress after subsequent chart removal fails Oct 19, 2026
@AustinAbro321 AustinAbro321 changed the title fix: correctly apply chart removal progress after subsequent chart removal fails fix: correctly save chart removal progress after subsequent chart removal fails Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/remove.go 83.33% 1 Missing ⚠️
Files with missing lines Coverage Ξ”
src/pkg/packager/remove.go 44.20% <83.33%> (+44.20%) ⬆️

... and 6 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brandtkeller
brandtkeller requested changes Oct 20, 2026
View reviewed changes

@brandtkeller brandtkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor observation for completeness.

Comment thread src/pkg/packager/remove.go Resolved
@github-project-automation github-project-automation Bot moved this to In progress in Zarf Oct 20, 2026
@AustinAbro321
fix
c42bcf6 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
brandtkeller
brandtkeller approved these changes Oct 21, 2026
View reviewed changes

@brandtkeller brandtkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brandtkeller
brandtkeller added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 59dc11f Oct 21, 2026
31 checks passed
@brandtkeller
brandtkeller deleted the fix-empty-slice-in-failed-remove branch October 21, 2026 19:10
@github-project-automation github-project-automation Bot moved this from In progress to Done in Zarf Oct 21, 2026
@zarf-release-please zarf-release-please Bot mentioned this pull request Oct 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Zarf
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zarf package remove leaves an empty chart entry in package state after a partial failure, so every retry fails with "Release name is invalid"

2 participants

@AustinAbro321 @brandtkeller