Skip to content

feat: implement zarf dev lint for v1beta1 packages and component configs - #5431

Merged
AustinAbro321 merged 1 commit into
mainfrom
v1beta1/lint
Oct 7, 2026
Merged

AustinAbro321 merged 1 commit into
mainfrom
v1beta1/lint

Conversation

@AustinAbro321

Copy link
Copy Markdown
Member

Description

Implements zarf dev lint for v1beta1 packages and component configs

Related Issue

Relates to #5165

Checklist before merging

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.96703% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/lint.go 68.75% 10 Missing and 5 partials ⚠️
src/pkg/packager/load/component.go 60.86% 6 Missing and 3 partials ⚠️
src/pkg/lint/rules_v1beta1.go 91.02% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/lint/rules_common.go 100.00% <100.00%> (ø)
src/pkg/lint/rules_v1alpha1.go 100.00% <100.00%> (ø)
src/pkg/lint/rules_v1beta1.go 91.02% <91.02%> (ø)
src/pkg/packager/load/component.go 70.58% <60.86%> (+1.35%) ⬆️
src/pkg/packager/lint.go 56.06% <68.75%> (-13.94%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321
AustinAbro321 marked this pull request as ready for review October 2, 2026 20:41
@AustinAbro321
AustinAbro321 requested review from a team as code owners October 2, 2026 20:41
@AustinAbro321
AustinAbro321 added this pull request to stack #5432 October 2, 2026 20:41
@netlify

netlify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit dfdab06
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6ac69b64ac5ba4000886b925
😎 Deploy Preview https://deploy-preview-5431--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

soltysh
soltysh previously approved these changes Oct 5, 2026

@soltysh soltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 changed the title feat: Implement zarf dev lint for v1beta1 packages and component configs feat: implement zarf dev lint for v1beta1 packages and component configs Oct 6, 2026
@AustinAbro321
AustinAbro321 force-pushed the v1beta1/lint branch 2 times, most recently from 56163cb to 9e264d7 Compare October 7, 2026 16:14
Base automatically changed from v1beta1/find-images to main October 7, 2026 19:19
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Comment thread src/pkg/packager/lint.go Resolved

@brandtkeller brandtkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321
AustinAbro321 added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit c3c98c1 Oct 7, 2026
@AustinAbro321
AustinAbro321 deleted the v1beta1/lint branch October 7, 2026 20:28
@github-project-automation github-project-automation Bot moved this to Done in Zarf Oct 7, 2026
AustinAbro321 added a commit that referenced this pull request Oct 8, 2026
…igs (#5431)

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants