Repository navigation
fix(assemble): cleanup temporary directory on error - #5407
Merged
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
β Deploy Preview for zarf-docs canceled.
|
Codecov Reportβ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes π New features to boost your workflow:
|
AustinAbro321
approved these changes
Sep 28, 2026
sei-pearl
pushed a commit
to sei-pearl/zarf
that referenced
this pull request
Oct 1, 2026
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds cleaning up the temporary directory during assembly, given an error, which previously would have orphaned the current state of the contents of that build directory.
Noticed this when toying with the implications of errors on actions. A successful AssemblePackage caller owns pkgLayout and must call Cleanup() after final use. Failed AssemblePackage calls return no usable layout, so AssemblePackage itself must remove buildPath.
Related Issue
No associated issue.
Checklist before merging