Repository navigation
Match feature names case-sensitively - #596
Open
marcoscaceres wants to merge 2 commits into
Open
marcoscaceres wants to merge 2 commits into
marcoscaceres wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The specification changes consistently implement the described case-sensitive matching behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Clarifies that permissions-policy feature names match feature tokens case-sensitively.
Changes:
- Uses exact string matching for HTTP header feature names.
- Applies the same matching rule to iframe
allowattributes.
| File | Description |
|---|---|
index.bs |
Specifies exact feature-token matching in both parsing algorithms. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
Can the two pairs of lines be re-written to have fewer duplicated words? I feel like it could be one line that says |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spell out that a feature name must exactly match a feature's token, in both the header and the allow attribute steps. WebKit and Chromium already match case-sensitively; Gecko matches case-insensitively.
Tests: web-platform-tests/wpt#63316
Preview | Diff