Skip to content

refactor: remove node env flag - #1749

Merged
kiaking merged 2 commits into
4.0from
replace-node-env
May 14, 2020
Merged

refactor: remove node env flag#1749
kiaking merged 2 commits into
4.0from
replace-node-env

Conversation

@cuebit

@cuebit cuebit commented May 13, 2020

Copy link
Copy Markdown
Member

Replaces the orphaned process.env.NODE_ENV with the new global __DEV__.

@cuebit cuebit added the 4.x label May 13, 2020
@cuebit
cuebit requested a review from kiaking May 13, 2020 23:44
kiaking
kiaking approved these changes May 14, 2020
View reviewed changes

@kiaking kiaking left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@kiaking kiaking added the bug Something isn't working label May 14, 2020
@kiaking
kiaking merged commit 0fea8c4 into 4.0 May 14, 2020
@kiaking
kiaking deleted the replace-node-env branch May 14, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiaking kiaking kiaking approved these changes

Assignees

@cuebit cuebit

Labels

4.x bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cuebit @kiaking