Skip to content

fix: unescape the field (datum access path) correctly for binned time unit - #9660

Merged
kanitw merged 3 commits into
mainfrom
yh/utcOffset-escaping
Aug 27, 2025
Merged

kanitw merged 3 commits into
mainfrom
yh/utcOffset-escaping

Conversation

@yhoonkim

Copy link
Copy Markdown
Contributor

PR Description

fix the bug that doesn't work with the fieldname having the signle quote for binned time unit

@yhoonkim
yhoonkim requested a review from a team as a code owner August 25, 2025 22:40
@yhoonkim
yhoonkim requested a review from kanitw August 25, 2025 22:40
@yhoonkim
yhoonkim force-pushed the yh/utcOffset-escaping branch from be1d7ba to 94996b1 Compare August 26, 2025 03:08
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 26, 2025 •

Copy link
Copy Markdown

Deploying vega-lite with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: dbff96f
Status:Β βœ…Β  Deploy successful!
Preview URL: https://a80fded5.vega-lite.pages.dev
Branch Preview URL: https://yh-utcoffset-escaping.vega-lite.pages.dev

View logs

Comment thread test/compile/data/timeunit.test.ts Resolved
@yhoonkim
yhoonkim force-pushed the yh/utcOffset-escaping branch from 94996b1 to 834d884 Compare August 26, 2025 20:35
@yhoonkim
yhoonkim requested a review from kanitw August 26, 2025 20:47
@kanitw
kanitw merged commit 0780bf1 into main Aug 27, 2025
@kanitw
kanitw deleted the yh/utcOffset-escaping branch August 27, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants