Skip to content

Add newtypes for bool fields/params/return types - #121060

Merged
bors merged 8 commits into
rust-lang:masterfrom
clubby789:bool-newtypes
Feb 25, 2024
Merged

Add newtypes for bool fields/params/return types#121060
bors merged 8 commits into
rust-lang:masterfrom
clubby789:bool-newtypes

Conversation

@clubby789

@clubby789 clubby789 commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Fixed all the cases of this found with some simple searches for */ bool and bool /*; probably many more

@rustbot

rustbot commented Feb 14, 2024

Copy link
Copy Markdown
Collaborator

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 14, 2024
@clubby789 clubby789 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Feb 14, 2024
cjgillot
cjgillot reviewed Feb 18, 2024
View reviewed changes
Comment thread compiler/rustc_expand/src/mbe/macro_rules.rs Outdated
Comment thread compiler/rustc_parse/src/parser/item.rs Outdated
Comment thread compiler/rustc_parse/src/parser/pat.rs Outdated
Comment thread compiler/rustc_parse/src/parser/diagnostics.rs Outdated
Comment thread compiler/rustc_codegen_llvm/src/intrinsic.rs
Comment thread compiler/rustc_resolve/src/ident.rs Outdated
@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
@clubby789 clubby789 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2024
@bors

bors commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #121327) made this pull request unmergeable. Please resolve the merge conflicts.