Skip to content

Commit 18fdcbd

Browse files
committed
fail CI if conformance fails
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
1 parent a5582e3 commit 18fdcbd

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

β€Ž.github/workflows/build-pr.ymlβ€Ž

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,8 @@ jobs:
3838
echo "Found report.html."
3939
echo "has-report=true" >> $GITHUB_OUTPUT
4040
fi
41-
42-
# TODO: Fail with CONFORMANCE_RC if non-zero
43-
# (conformance not yet passing for this registry)
4441
echo "Conformance return code: ${CONFORMANCE_RC}"
45-
exit 0
42+
exit ${CONFORMANCE_RC}
4643
4744
- name: Upload OCI conformance results as build artifact
4845
if: always() && steps.tests.outputs.has-report == 'true'

β€Ž.github/workflows/build.ymlβ€Ž

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,8 @@ jobs:
3838
echo "Found report.html."
3939
echo "has-report=true" >> $GITHUB_OUTPUT
4040
fi
41-
42-
# TODO: Fail with CONFORMANCE_RC if non-zero
43-
# (conformance not yet passing for this registry)
4441
echo "Conformance return code: ${CONFORMANCE_RC}"
45-
exit 0
42+
exit ${CONFORMANCE_RC}
4643
4744
- name: Upload OCI conformance results as build artifact
4845
if: always() && steps.tests.outputs.has-report == 'true'

0 commit comments

Comments
Β (0)