Repository navigation
nut-scanner: consolidate library selection - #3760
Open
user01010111 wants to merge 5 commits into
Open
user01010111 wants to merge 5 commits into
user01010111 wants to merge 5 commits into
Conversation
added 2 commits
October 15, 2026 11:25
Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 63bbb15 is temporarily available: NUT-tarballs-PR-3760.zip. |
jimklimov
approved these changes
Oct 15, 2026
|
✅ Build nut 2.8.5.5880-master completed (commit 13c001b6b4 by @jimklimov)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the load-reporting changes in #3739, consolidate the repeated library selection in
tools/nut-scanner/nutscan-init.cinto one private helper and explicit candidate lists. Preserve resolver-first lookup, fallback ordering, unload/reset behaviour, availability results and diagnostics, including libupsclient's different Windows ordering. Adapter loaders and public interfaces remain unchanged.Compatibility and platform-specific rationale comments are retained beside the shared helper or candidate lists.
Add
tests/nutscan-selection-test.cand register nine variants intests/Makefile.am. The tests exercise real initialisation and the shared unloader with independent expectations for candidate order, entry and re-entry state, ownership and logging.Validation:
NDEBUGenabled.make distcheck-lightand style checks passed; the archive contains the tested versions of the three code and build files.Valgrind checks of the production library-selection and loading/cleanup paths reported no errors or lost blocks; retained allocations matched the baseline.
AI assistance: OpenAI Codex for implementation and tests; Claude Opus 5.5 for review.