Bug 2037243 - Force updates on force installed extensions. r=jmendez

Differential Revision: https://phabricator.services.mozilla.com/D298694

Author: mkaply

browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js

@@ -120,6 +120,48 @@ add_task(async function test_extensionsettings() {
   );
 });
 
+add_task(async function test_force_installed_updates_disabled() {
+  await setupPolicyEngineWithJson({
+    policies: {
+      ExtensionSettings: {
+        "force@mozilla.com": {
+          installation_mode: "force_installed",
+          install_url: "https://example.com/test.xpi",
+        },
+        "force_explicit@mozilla.com": {
+          installation_mode: "force_installed",
+          install_url: "https://example.com/test.xpi",
+          updates_disabled: true,
+        },
+        "normal@mozilla.com": {
+          installation_mode: "normal_installed",
+          install_url: "https://example.com/test.xpi",
+        },
+      },
+    },
+  });
+
+  equal(
+    Services.policies.getExtensionSettings("force@mozilla.com")
+      .updates_disabled,
+    false,
+    "force_installed with no updates_disabled should default to false"
+  );
+  equal(
+    Services.policies.getExtensionSettings("force_explicit@mozilla.com")
+      .updates_disabled,
+    true,
+    "force_installed with explicit updates_disabled: true should be respected"
+  );
+  ok(
+    !(
+      "updates_disabled" in
+      Services.policies.getExtensionSettings("normal@mozilla.com")
+    ),
+    "non-force_installed should not synthesize updates_disabled"
+  );
+});
+
 add_task(async function test_addon_blocked() {
   await setupPolicyEngineWithJson({
     policies: {

toolkit/components/enterprisepolicies/EnterprisePoliciesParent.sys.mjs

@@ -426,15 +426,23 @@ EnterprisePoliciesManager.prototype = {
   },
 
   getExtensionSettings(extensionID) {
-    let settings = null;
-    if (ExtensionSettings) {
-      if (extensionID in ExtensionSettings) {
-        settings = ExtensionSettings[extensionID];
-      } else if ("*" in ExtensionSettings) {
-        settings = ExtensionSettings["*"];
+    if (!ExtensionSettings) {
+      return null;
+    }
+    if (extensionID in ExtensionSettings) {
+      const settings = ExtensionSettings[extensionID];
+      if (
+        settings.installation_mode === "force_installed" &&
+        !("updates_disabled" in settings)
+      ) {
+        return { ...settings, updates_disabled: false };
       }
+      return settings;
     }
-    return settings;
+    if ("*" in ExtensionSettings) {
+      return ExtensionSettings["*"];
+    }
+    return null;
   },
 
   isAddonRequiredByPolicy(addonID) {