agent: server ID in banner should be persistent - #28276
Merged
Merged
Conversation
During agent startup on a server, we log the server node ID in the banner. But instead of using the node ID we got during the initial setup (or from the persistent ID on disk), we regenerate the ID. In fact, we regenerate the entire configuration for the purpose of displaying this one log line and then throw it out! Fix this by using the node ID already available on the server.
tgross
force-pushed
the
nmd1644-node-id-logging
branch
from
July 21, 2026 22:15
d155498 to
4a5cd22
Compare
tgross
marked this pull request as ready for review
July 21, 2026 22:18
8 tasks
schmichael
pushed a commit
to vercel/nomad
that referenced
this pull request
Sep 25, 2026
During agent startup on a server, we log the server node ID in the banner. But instead of using the node ID we got during the initial setup (or from the persistent ID on disk), we regenerate the ID. In fact, we regenerate the entire configuration for the purpose of displaying this one log line and then throw it out! Fix this by using the node ID already available on the server.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During agent startup on a server, we log the server node ID in the banner. But instead of using the node ID we got during the initial setup (or from the persistent ID on disk), we regenerate the ID. In fact, we regenerate the entire configuration for the purpose of displaying this one log line and then throw it out!
Fix this by using the node ID already available on the server.
Testing & Reproduction steps
Logs:
Logs after restart:
Contributor Checklist
changelog entry using the
make clcommand.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.