Support uploading client ACL tokens - #27741
Merged
Merged
Conversation
allisonlarson
force-pushed
the
f-provide-client-tokens
branch
from
May 19, 2026 18:42
1c1f590 to
7690cb3
Compare
tgross
previously approved these changes
May 19, 2026
tgross
left a comment
tgross
left a comment
Member
There was a problem hiding this comment.
LGTM!
I've left a few minor comments but once those are resolved this should be ready-to-go!
Contributor
Author
|
@tgross All updated & ready for another look. I'm not sure why I didn't catch the testing library mishap during the original dev; thank you for pointing it out! I also added an UUID check where you suggested. |
7 tasks
Merged
15 tasks
aimeeu
added a commit
to hashicorp/web-unified-docs
that referenced
this pull request
Jun 2, 2026
<!-- **Merge branch** Make sure you create your PR against the correct **base** branch. For instructions, refer to GitHub's **Change the branch range and destination repository guide** (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request). If your content is an update to: - Currently published content Choose **base: main** when you are updating published documentation, and you want your changes published when the PR is merged. We publish Nomad content from the `main` branch. - Upcoming Nomad release Choose the branch for the Nomad release that your content is for. Nomad release branches use the `nomad/<exact-release-number>` format. If you are not able to find the upcoming Nomad release branch that you are looking for, contact the tech writer that works with the Nomad team. - Upcoming Nomad release but not sure which one - Choose the `main` branch. - Add the "do not merge" label. - Convert the PR to a DRAFT. - Put an explanation in the **Description** section. The tech writer coordinates with Nomad engineering and updates the docs PR base branch when the code is slotted into an upcoming release. **Backports** This repo stores previous version docs in folders instead of branches. There are no backport labels. If you backported your code PR to previous branches, update the docs content in the corresponding folders. For example, if the current release is 1.10.x and you backported your code to 1.9.x and 1.8.x, update the docs content in the v1.10.x, v1.9.x, and v1.8.x folders. If you can't find the relevant files in previous versions, add a note to your PR description. The tech writer will help ensure that the previous versions receive the correct updates. --> ## Description <!-- Please describe why you're making this change and point out any important details the reviewers should be aware of. A robust description helps the tech writer create a fabulous release note. If your code PR has a splendid description, link to the code PR in the links section so that the tech writer can update this PR's description. Include the target release as well as prior versions if applicable. --> Adds information about how to upload client ACL tokens using the `acl token create` command ## Links <!-- **Please link to the related Nomad repo code PR!** if there is one. The tech writer does look at the code PR description, Jira ticket, and/or GH issue before reviewing docs content. Include links to GitHub issues, documentation, or similar which is relevant to this PR. If this is a docs bug fix, please ensure related issues are linked so they will close when this PR is merged. // GH-Jira integration generates the link and updates the Jira ticket. Jira: [<jira-ticket-number>] // for example, Jira: [NMD-1234] GitHub Issue: <issue-link> Deploy previews: The bot does publish a root-level link to the deploy preview, but the preview URL changes with each build. --> Nomad Code PR: hashicorp/nomad#27741 Jira: https://hashicorp.atlassian.net/browse/NMD-352 GitHub Issue: hashicorp/nomad#24457 ## Contributor checklists Review urgency: - [ ] ASAP: Bug fixes, broken content, imminent releases - [x] 3 days: Small changes, easy reviews - [x] 1 week: Default expectation - [ ] Best effort: No urgency Pull request: - [x] Verify that the PR is set to merge into the correct base branch - [ ] Verify that all status checks passed - [ ] Verify that the preview environment deployed successfully - [ ] Add additional reviewers if they are not part of assigned groups Content: - [ ] I added redirects for any moved or removed pages - [ ] I followed the [Education style guide](https://github.com/hashicorp/web-unified-docs/tree/main/docs/style-guide) - [ ] I looked at the local or Vercel build to make sure the content rendered correctly ## Reviewer checklist - [ ] This PR is set to merge into the correct base branch. - [ ] The content does not contain technical inaccuracies. - [ ] The content follows the Education content and style guides. - [ ] I have verified and tested changes to instructions for end users. [NMD-1234]: https://hashicorp.atlassian.net/browse/NMD-1234?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for uploading client ACL tokens by supplying the
accessorIDandsecretIDduring creation. The commandnomad acl token createnow takes an optional-accessorflag, and the secretID is provided either by a filepath or through stdin (-), following hownomad acl bootstrapaccepts the secretID. If the accessor is provided, the secretID is required; similarly, if the secretID is passed, the accessor is required. Management tokens are not allowed to be uploaded in this way.I've added a new
ACLTokens.Uploadfunction to the api package for clarity and clear validation message, but it still uses the same http path & requests. I can collapse this into the sameACLTokens.Create, but the specificity felt nicer.Testing & Reproduction steps
tests were added, and tested manually
Links
Issue: #24457
Internal ref: https://hashicorp.atlassian.net/browse/NMD-352
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.