Skip to content

fix(theme): fix legend page text color in dark mode - #20396

Merged
Ovilia merged 1 commit into
masterfrom
fix/legend-page-text-color-in-dark-theme
Oct 8, 2024
Merged

Ovilia merged 1 commit into
masterfrom
fix/legend-page-text-color-in-dark-theme

Conversation

@plainheart

@plainheart plainheart commented Oct 8, 2024 •

Copy link
Copy Markdown
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the legend page text color is not light in the dark mode.

Fixed issues

#20395

Details

Before: What was the problem?

Demo

Before

After: How does it behave after the fixing?

Demo

After

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the last case in test/legend.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot

echarts-bot Bot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.2 milestone Oct 8, 2024
@github-actions

github-actions Bot commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20396@4704cbc

@Ovilia
Ovilia merged commit b33058e into master Oct 8, 2024
@echarts-bot

echarts-bot Bot commented Oct 8, 2024

Copy link
Copy Markdown

Congratulations! Your PR has been merged. Thanks for your contribution! πŸ‘

@Ovilia
Ovilia deleted the fix/legend-page-text-color-in-dark-theme branch October 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] dark theme not correct for line chart with legend type 'scroll'

2 participants