Skip to content

feat(axis): support tooltip for axis label - #16315

Merged
plainheart merged 2 commits into
masterfrom
feat/axis-label-tooltip
Nov 24, 2024
Merged

plainheart merged 2 commits into
masterfrom
feat/axis-label-tooltip

Conversation

@plainheart

@plainheart plainheart commented Jan 4, 2022 •

Copy link
Copy Markdown
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Support tooltip for the axis label. It's useful for the case in which the axis label is truncated for long text and hope to show the full text when hovering on the label.

Fixed issues

Details

Before: What was the problem?

No tooltip for showing the full text of a truncated axis label. The developer has to simulate a tooltip via listening to the mouse event like https://codepen.io/plainheart/pen/jOGBrmJ.

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the last test case in test/axisLabel.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot

echarts-bot Bot commented Jan 4, 2022

Copy link
Copy Markdown

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Thj007

Thj007 commented Jul 17, 2022

Copy link
Copy Markdown

ๆ€Žไนˆไฝฟ็”จๅ‘ข๏ผŸ

@plainheart

Copy link
Copy Markdown
Member Author

@Thj007 ๅฏไปฅๅ‚่€ƒ PR ้‡Œ้™„ๅŠ ็š„ๆต‹่ฏ•็”จไพ‹ test/axisLabel.html

@plainheart
plainheart requested review from Ovilia and pissang August 13, 2022 02:24
@Ovilia Ovilia modified the milestones: 5.4, 5.4.1 Sep 1, 2022
Ovilia
Ovilia previously approved these changes Sep 2, 2022

@Ovilia Ovilia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with the test case and it looks cool. LGTM

@echarts-bot

echarts-bot Bot commented Sep 2, 2022

Copy link
Copy Markdown

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@Ovilia

Ovilia commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

@pissang Please double-click this PR.

@plainheart I think a new option is probably required? Please check the "The API has been changed" and prepare the document later.

@Ovilia
Ovilia requested a review from 100pah September 22, 2022 09:59
@plainheart
plainheart changed the base branch from next to master October 8, 2022 09:16
Comment thread src/component/axis/AxisBuilder.ts Resolved
@plainheart plainheart added the discussion-required Further discussion is required before we decide if this issue should be fixed. label Oct 14, 2022
@plainheart plainheart modified the milestones: 5.4.1, 5.5.0 Nov 10, 2022
@plainheart plainheart removed this from the 5.5.0 milestone Feb 25, 2023
@plainheart plainheart changed the title feat(axis): support tooltip for axis label. feat(axis): support tooltip for axis label Jul 17, 2024
@shenxiang216

Copy link
Copy Markdown

ๆœŸๅพ…็œ‹ๅˆฐ่ฏฅๅŠŸ่ƒฝ็š„ๅˆๅนถ๏ผ

@tracyfarah

Copy link
Copy Markdown

@pissang @100pah can we please merge this thanks :)

@FirstVertex

Copy link
Copy Markdown

Please, let's do it! We have the same requirement about tooltip on Axis label only whey they are overflowed. Thanks!

Comment thread src/component/axis/AxisBuilder.ts Resolved
Comment thread src/component/axis/AxisBuilder.ts Resolved
@plainheart
plainheart force-pushed the feat/axis-label-tooltip branch from 155653f to 8f7773c Compare November 23, 2024 01:55
@plainheart plainheart removed the discussion-required Further discussion is required before we decide if this issue should be fixed. label Nov 23, 2024
@plainheart
plainheart merged commit 8924cb5 into master Nov 24, 2024
@echarts-bot

echarts-bot Bot commented Nov 24, 2024

Copy link
Copy Markdown

Congratulations! Your PR has been merged. Thanks for your contribution! ๐Ÿ‘

@plainheart
plainheart deleted the feat/axis-label-tooltip branch November 24, 2024 06:06
@hughess

hughess commented Dec 30, 2024

Copy link
Copy Markdown

is this feature live? Can't seem to find it in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

10 participants