Repository navigation
[Android] - fix resource issue handling issue - #9602
Merged
ev-mp merged 2 commits intoAug 17, 2021
Merged
Conversation
ev-mp
changed the title
remibettan
reviewed
Aug 15, 2021
remibettan
left a comment
remibettan
left a comment
Contributor
There was a problem hiding this comment.
Please confirm that the memory profiler has been used in order to check that no leak happens because of these changes.
Contributor
Author
|
@remibettan yes, checked with both memory profiler and process profiler, memory did not leak over time after 200 2d-3d switches. The only time memory increases persistently is the first switch to 3d which we does setup for 3d display. in subsequent 2d-3d switches, memory all recovers - native memory recovers once switch back to 2d. java memory gradually recovers as part of garbage collection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part b fix to additional issues found when switching between 2d and 3d.
Changes:
Tracked on: DSO-16584