Repository navigation
Video profile eq - #8473
Merged
Merged
Video profile eq#8473
Conversation
ev-mp
requested changes
Mar 4, 2021
ev-mp
left a comment
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Put DSO reference in description
ev-mp
reviewed
Mar 8, 2021
| if (devices.size() == 0) return; | ||
| auto dev = devices[0]; | ||
|
|
||
| auto depth_sens = dev.first< rs2::depth_sensor >(); |
Contributor
There was a problem hiding this comment.
Add check for cast and exist gracefully if casting fails, i.e. with T265.
Alternatively, modify the flow to handle T265 as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video_stream_profile class is missing operator==
This cause 2 video_stream_profile objects to use the stream_profile::operator== instead which gives false results.
PR includes a test to demonstrate the issue and the fix.
Relates to DSO-16565