Skip to content

Add L515 humidity temperature option - #7490

Merged
ev-mp merged 1 commit into
realsenseai:developmentfrom
Nir-Az:add_hum_sensor_to_viewer
Oct 5, 2020
Merged

ev-mp merged 1 commit into
realsenseai:developmentfrom
Nir-Az:add_hum_sensor_to_viewer

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Oct 4, 2020 •

Copy link
Copy Markdown
Collaborator

Tracked on [RS5-9069]

GUI illustration :
image

@Nir-Az
Nir-Az requested a review from ev-mp October 4, 2020 09:06

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the missing enumerations

Comment thread include/librealsense2/h/rs_option.h Resolved
Comment thread src/l500/l500-depth.cpp Resolved
Comment thread wrappers/matlab/option.m Resolved
Comment thread wrappers/nodejs/index.js Resolved
Comment thread wrappers/nodejs/index.js Resolved
Comment thread wrappers/nodejs/src/addon.cpp Resolved
@Nir-Az
Nir-Az force-pushed the add_hum_sensor_to_viewer branch from cfd8a1c to 20fa453 Compare October 4, 2020 12:29
@Nir-Az
Nir-Az requested a review from ev-mp October 4, 2020 12:32
Comment thread include/librealsense2/h/rs_option.h Resolved
Comment thread include/librealsense2/h/rs_option.h Outdated
RS2_OPTION_SEQUENCE_NAME, /**< HDR Sequence name */
RS2_OPTION_SEQUENCE_SIZE, /**< HDR Sequence size */
RS2_OPTION_SEQUENCE_ID, /**< HDR Sequence ID - 0 is not HDR; sequence ID for HDR configuartion starts from 1 */
RS2_OPTION_HUMIDITY_TEMPERATURE, /**< Humidity temperature*/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls specify units

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread wrappers/python/pybackend.cpp Resolved
@Nir-Az
Nir-Az force-pushed the add_hum_sensor_to_viewer branch from 20fa453 to 6f9de94 Compare October 5, 2020 10:34
@Nir-Az
Nir-Az requested a review from ev-mp October 5, 2020 10:34

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp
ev-mp merged commit 1ef7b3a into realsenseai:development Oct 5, 2020
@Nir-Az
Nir-Az deleted the add_hum_sensor_to_viewer branch April 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants