Repository navigation
WIP: Hotfix for LRS Network Extensions - #6188
Merged
Merged
Conversation
ev-mp
requested changes
Apr 5, 2020
| std::unique_lock<std::mutex> lk(m_taskSchedulerMutex); | ||
| { | ||
| std::lock_guard<std::mutex> lk(m_taskSchedulerMutex); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't understand as the Lock_guard has no effect here.
Did you mean to move the var assignment into the scoped range ?
| throw std::runtime_error(format_error_msg(__FUNCTION__, err)); | ||
| } | ||
| m_commandDone = false; | ||
| unsigned res = this->sendTeardownCommand(*this->m_scs.m_session, this->continueAfterTEARDOWN); |
Contributor
There was a problem hiding this comment.
res is not used in the scope. You can either start checking the return value, or (in case there is no intend for it) drop it completely
Tabs
| StreamClientState &scs = rsRtspClient->m_scs; // alias | ||
|
|
||
| if(!resultStr.empty()) | ||
| if (!resultStr.empty()) |
Contributor
There was a problem hiding this comment.
You can move the whole flow under if (resultString) to make it concise.
| { | ||
| resultStr = resultString; | ||
| delete [] resultString; | ||
| delete[] resultString; |
Contributor
There was a problem hiding this comment.
Is it possible to refactor this so that the input string will be passed as const ref instead of pointers?
This is really not safe and prone to bugs, e.g. what happens if the input string is passed into a separate thread.
apuzhevi
force-pushed
the
ethernet
branch
2 times, most recently
from
April 21, 2020 10:50
8350fde to
412fd6c
Compare
* Server command line switches: -p <port> -i <addr> -c * Port as part of the address.
* Client-side buffer for Windows only
dorodnic
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.