Repository navigation
add check for D500 device before HWMC - #14170
Merged
Nir-Az merged 2 commits intoAug 17, 2025
Merged
Conversation
Nir-Az
reviewed
Jul 29, 2025
|
|
||
| bool dds_model::check_DDS_support() | ||
| { | ||
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE) || !(std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) == "D500")) |
Collaborator
There was a problem hiding this comment.
- lets please check specifically D555 Camera name
- Maybe the readability with be more clear with something like:
if !(supports && D555)
return false
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a device validation check to the DDS (Distributed Data Service) model, specifically requiring D500 devices before proceeding with DDS support validation. The change ensures that DDS functionality is only enabled for compatible D500 hardware.
- Adds a device type check that validates the product line is "D500" before enabling DDS support
- Returns false early if the device doesn't support product line info or isn't a D500 model
Comment on lines
+107
to
+113
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE) || !(std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) == "D500")) | ||
| return false; | ||
|
|
There was a problem hiding this comment.
Calling _device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE) without first checking if it's supported could throw an exception. The supports() check should be separated from the string comparison to avoid calling get_info() on an unsupported parameter.
Suggested change
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE) || !(std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) == "D500")) | |
| return false; | |
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE)) | |
| return false; | |
| if (std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) != "D500") | |
| return false; |
|
|
||
| bool dds_model::check_DDS_support() | ||
| { | ||
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE) || !(std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) == "D500")) |
There was a problem hiding this comment.
The magic string "D500" should be defined as a constant to improve maintainability and reduce the risk of typos in future changes.
Suggested change
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE) || !(std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) == "D500")) | |
| if (!_device.supports(RS2_CAMERA_INFO_PRODUCT_LINE) || !(std::string(_device.get_info(RS2_CAMERA_INFO_PRODUCT_LINE)) == rs2::PRODUCT_LINE_D500)) |
Collaborator
|
@Noy-Zini reminder |
Noy-Zini
force-pushed
the
fix-hwmc-0xBB-only-for-D555
branch
from
August 17, 2025 07:14
40c227c to
2bcd33e
Compare
Nir-Az
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDSO-20433]