Repository navigation
[RS-Viewer] 3D D455 model added - #11992
Merged
Nir-Az merged 2 commits intoJul 13, 2023
Merged
Conversation
D455 and D457 cameras use d455.h file
Nir-Az
reviewed
Jul 12, 2023
| if (starts_with(dev_name, "Intel RealSense D415")) index = 0; | ||
| if (starts_with(dev_name, "Intel RealSense D435")) index = 1; | ||
| if (starts_with(dev_name, "Intel RealSense L5")) index = 2; | ||
| if (starts_with(dev_name, "Intel RealSense D455") || starts_with(dev_name, "Intel RealSense D457")) index = 3; |
Collaborator
There was a problem hiding this comment.
Let's shorten this to :if (starts_with(dev_name, "Intel RealSense D45"))
It will catch both.
And please verify with both D455 & D457
Collaborator
|
Please add the obj filr you created before convert to h file |
Collaborator
|
Why is this PR draft? was it tested? ready for review? |
Collaborator
Added |
Tamir91
marked this pull request as ready for review
July 13, 2023 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-685]