Closed Bug 2073149 Opened 1 month ago Closed 27 days ago

Consider disabling nimbus/labs/rollouts/studies by default and skip tests

Categories

(Enterprise Products :: Firefox, defect, P2)

Tracking

(firefox160 verified)

VERIFIED FIXED
Tracking Status
firefox160 --- verified

People

(Reporter: jporter, Assigned: janika)

References

Details

Attachments

(1 external file)

Bug 2059726 flipped the Nimbus optout pref by default, which regressed some tests in bug 2070454, which was resolved by restoring the prefs in the tests. We should investigate and consider what needs disabling in Enterprise around Nimbus, Labs, Normandy, Rollouts, Studies, etc, and skip tests where appropriate.

Summary: Disable nimbus/labs/rollouts/studies by default and skip tests → Consider disabling nimbus/labs/rollouts/studies by default and skip tests

Should we continue to keep the pref override in toolkit/components/nimbus/test/NimbusTestUtils.sys.mjs, the implementation of the pref overriding for tests should also be refactored, per comment here: https://github.com/mozilla/enterprise-firefox/pull/1505/changes#diff-aa156e9f8f20e62e7fb1e342621aec8da10a9d0d42506e62708cf9e40a0da5a0R41-R48.

This should both assert that our pref is false by default before flipping, and it should also clean up and revert back to false after testing.

Severity: -- → S2
Priority: -- → P2

Authored by https://github.com/1rneh
https://github.com/mozilla/enterprise-firefox/commit/ebe5d711541fe6775a7742a39dddd396d3337fe7
[enterprise-main] Bug 2073149 - Disable Nimbus studies, rollouts, Firefox Labs and Normandy (#1679)

(via GitHub webhook, authenticated as shared-secret)

Status: NEW → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED

Setting this one as qe-verify+: Josh do you have any hints for QA to test this? Thanks!

Flags: qe-verify+
Flags: needinfo?(joporter)

Hey Brian,

Outside of just checking that the prefs changed here are properly flipped/locked, here are some UI areas that could be verified

  • Firefox Labs section should not appear in the sidebar
  • about:preferences#experimental should not show the Labs pane
  • about:preferences#tabsBrowsing "Recommend extensions as you browse" and "Recommend features as you browse" should be unchecked and disabled
  • about:preferences#permissionsData: the studies and rollouts checkboxes should still be absent from the "Firefox Enterprise data collection and use" section (already hidden by Bug 2059726, so this is a regression check)
  • Typing "labs" into the urlbar should not show the "Open Firefox Labs" quick action

about:support and about:studies could be checked as well, but I think those tables were already empty before and still appear to be empty, so I don't think anything has changed there.

Thanks!

Assignee: nobody → jneuberger
Flags: needinfo?(joporter)
QA Contact: pmagyari

Verified on Firefox Enterprise 160.0a1 (20261021060352): the corresponding prefs are set to false by default, and those sections no longer appear in about:preferences.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Also verified on Firefox Enterprise 160.0 (20261105165157).

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: