Closed Bug 2065965 Opened 2 months ago Closed 2 months ago

ExtensionSettings that used to work don't

Categories

(Firefox :: Enterprise Policies, defect)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
156 Branch
Tracking Flags:
Tracking Status
firefox-esr140 --- unaffected
firefox-esr153 155+ fixed
firefox154 --- wontfix
firefox155 + fixed
firefox156 + fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 external files)

We had a customer report that using "true" boolean value no longer works with the new schema.

Technically that's incorrect, but because of the way our parsing works, if there is an invalid boolean in ExtensionSettings (private_browsing) it throws out all of ExtensionSettings.

So

  1. We should allow "true" and "false" for booleans - common mistake,.
  2. We shouldn't throw out everything when one thing fails.

[Tracking Requested - why for this release]: This is a major issue for this customer. Want to get this in ASAP.

Severity: -- → S1
tracking-firefox154: --- → ?
tracking-firefox155: --- → ?
tracking-firefox156: --- → ?
Priority: -- → P1

Set release status flags based on info from the regressing bug 2044429

status-firefox154: --- → affected
status-firefox155: --- → affected
status-firefox156: --- → affected
status-firefox-esr140: --- → unaffected
status-firefox-esr153: --- → affected
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Severity: S1 → S2
status-firefox154: affected → wontfix
tracking-firefox154: ? → ---
tracking-firefox155: ? → +
tracking-firefox156: ? → +
tracking-firefox-esr153: --- → 155+
Priority: P1 → --
Pushed by mozilla@kaply.com: https://github.com/mozilla-firefox/firefox/commit/618ad267c49d https://hg.mozilla.org/integration/autoland/rev/1d88962cb673 Tolerate quoted booleans and per-entry errors in policy validation. r=bsmth

https://hg.mozilla.org/mozilla-central/rev/1d88962cb673

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox156: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch

The patch landed in nightly and beta is affected, along with ESR.
:mkaply, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(mozilla)
Attachment #9630533 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: We have reports from customers that existing policy is not working.
    It's a mistake on their end, but we should handle it for compatibility.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Very isolated. Only affects this one policy case.
  • String changes made/needed?: None
  • Is Android affected?: no
Attachment #9630534 - Flags: approval-mozilla-esr153?

firefox-esr153 Uplift Approval Request

  • User impact if declined/Reason for urgency: We have reports from customers that existing policy is not working.
    It's a mistake on their end, but we should handle it for compatibility.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Very isolated. Only affects this one policy case.
  • String changes made/needed?: None
  • Is Android affected?: no
Flags: in-testsuite+
Attachment #9630533 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9630534 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
QA Whiteboard: [qa-triage-done-c157/b156]
See Also: → 2067099
Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: