Closed Bug 2063975 Opened 2 months ago Closed 2 months ago

"DisablePrivateBrowsing":true does not hide the "New Private Window" item in the "File" menu of the menubar

Categories

(Firefox :: Enterprise Policies, defect)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
156 Branch
Tracking Flags:
Tracking Status
firefox-esr140 --- unaffected
firefox-esr153 156+ fixed
firefox154 --- wontfix
firefox155 --- wontfix
firefox156 --- fixed

People

(Reporter: yuki, Assigned: mkaply)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 external files)

Steps to reproduce

  1. Put distribution/policies.json with the contents: 
    {
  "policies": {
    "DisablePrivateBrowsing": true
  }
}
  2. Start Firefox.
  3. Press ALT key to show the menubar, and open the "File" menu.

Actual result

The "File" menu has the item "New Private Window", and it opens a new regular window (not in private browsing mode).

Expected result

The "File" menu does not have the item "New Private Window".

#Environment

  • FIrefox 156.0a1 build ID: 20260816214904 on Windows 11
  • FIrefox 153.0esr build ID: 20260716160951 on Windows 11

I swear that used to not be there.

Keywords: regression
Regressed by: 2010038
Assignee: nobody → mozilla
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 2010038

status-firefox154: --- → affected
status-firefox155: --- → affected
status-firefox-esr140: --- → unaffected
status-firefox-esr153: --- → affected
Pushed by mozilla@kaply.com: https://github.com/mozilla-firefox/firefox/commit/cb7f9b6d22e1 https://hg.mozilla.org/integration/autoland/rev/99665606d49d Hide the File menu New Private Window item when private browsing is disabled. r=emilio

https://hg.mozilla.org/mozilla-central/rev/99665606d49d

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox156: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch

:mkaply, do you want to consider adding an uplift request for esr153?

Flags: needinfo?(mozilla)

firefox-esr153 Uplift Approval Request

  • User impact if declined/Reason for urgency: Regression with enterprise policy
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Simple change.
  • String changes made/needed?: None
  • Is Android affected?: no
Attachment #9629026 - Flags: approval-mozilla-esr153?
Flags: needinfo?(mozilla)
Attachment #9629026 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: